-
Notifications
You must be signed in to change notification settings - Fork 7.1k
port RandomZoomOut from detection references to prototype transforms #5551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 09f5191 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmeier Thanks! Overall looks good, but I got some comments. Let me know your thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment for a potential bug. Other than that it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…into transforms/zoom-out
…ansforms (#5551) Summary: * port RandomZoomOut from detection references to prototype transforms * copy by default * move padding parsing to stable API * merge zoom out kernels into transform * lint * fix filling if no padding was done * resolve todo Reviewed By: vmoens Differential Revision: D34878967 fbshipit-source-id: 973e8c088d38c0d2849a557b3a3d83e98dc8bf63
Addresses #5542.
Example script to be run in
references/detection
: